Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the redundant return value of the open function #1120

Merged
merged 1 commit into from Jun 23, 2022

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Jun 23, 2022

small optimization

@CLAassistant
Copy link

CLAassistant commented Jun 23, 2022

CLA assistant check
All committers have signed the CLA.

Signed-off-by: SimFG <1142838399@qq.com>
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #1120 (9ab0187) into master (78c80fb) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1120   +/-   ##
=======================================
  Coverage   98.32%   98.32%           
=======================================
  Files          49       49           
  Lines        2147     2147           
=======================================
  Hits         2111     2111           
  Misses         28       28           
  Partials        8        8           
Impacted Files Coverage Δ
writer.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78c80fb...9ab0187. Read the comment docs.

@sywhang sywhang merged commit 56b4e2b into uber-go:master Jun 23, 2022
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants