Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use errors.New instead of format function without args for error #1134

Merged
merged 1 commit into from Jul 21, 2022
Merged

chore: use errors.New instead of format function without args for error #1134

merged 1 commit into from Jul 21, 2022

Conversation

sashamelentyev
Copy link
Contributor

@sashamelentyev sashamelentyev commented Jul 21, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #1134 (5683101) into master (2cfc92c) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1134      +/-   ##
==========================================
+ Coverage   98.23%   98.32%   +0.09%     
==========================================
  Files          49       49              
  Lines        2147     2147              
==========================================
+ Hits         2109     2111       +2     
+ Misses         29       28       -1     
+ Partials        9        8       -1     
Impacted Files Coverage Δ
config.go 100.00% <100.00%> (ø)
encoder.go 100.00% <100.00%> (ø)
http_handler.go 100.00% <100.00%> (ø)
zapcore/sampler.go 100.00% <0.00%> (+3.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Contributor

@sywhang sywhang left a comment

LGTM, thanks for the contribution.

@sywhang sywhang merged commit e3a10fc into uber-go:master Jul 21, 2022
6 checks passed
@sashamelentyev sashamelentyev deleted the chore/err branch Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants