Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Lint against 1.19 #1141

Merged
merged 2 commits into from Aug 2, 2022
Merged

CI: Lint against 1.19 #1141

merged 2 commits into from Aug 2, 2022

Conversation

abhinav
Copy link
Contributor

@abhinav abhinav commented Aug 2, 2022

We prefer to lint against the latest release.

We prefer to lint against the latest release.
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #1141 (cc96a0e) into master (7ee98d2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1141   +/-   ##
=======================================
  Coverage   98.32%   98.32%           
=======================================
  Files          49       49           
  Lines        2146     2146           
=======================================
  Hits         2110     2110           
  Misses         28       28           
  Partials        8        8           
Impacted Files Coverage Δ
array_go118.go 100.00% <ø> (ø)
http_handler.go 100.00% <ø> (ø)
logger.go 96.66% <ø> (ø)
options.go 100.00% <ø> (ø)
sugar.go 100.00% <ø> (ø)
zapcore/buffered_write_syncer.go 100.00% <ø> (ø)
zapcore/encoder.go 87.09% <ø> (ø)
zapcore/entry.go 92.77% <ø> (ø)
zapcore/error.go 96.77% <ø> (ø)
zapcore/json_encoder.go 100.00% <ø> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gofmt now changes godoc formatting to match the new godoc format.
https://go.dev/doc/comment
sywhang
sywhang approved these changes Aug 2, 2022
@abhinav abhinav merged commit ee349f9 into master Aug 2, 2022
11 checks passed
@abhinav abhinav deleted the lint-119 branch Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants