Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup use of assert.Error/Contains with ErrorContains #1158

Merged
merged 1 commit into from Aug 25, 2022

Conversation

prashantv
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #1158 (771c0b9) into master (1ae5819) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1158      +/-   ##
==========================================
- Coverage   98.33%   98.24%   -0.10%     
==========================================
  Files          49       49              
  Lines        2163     2163              
==========================================
- Hits         2127     2125       -2     
- Misses         28       29       +1     
- Partials        8        9       +1     
Impacted Files Coverage Δ
zapcore/sampler.go 96.29% <0.00%> (-3.71%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@abhinav abhinav merged commit 0d6a75b into uber-go:master Aug 25, 2022
7 checks passed
@prashantv prashantv deleted the prashantv/err-contains branch August 25, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants