Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export objectMarshalerPtr #1171

Merged
merged 1 commit into from Aug 30, 2022
Merged

Conversation

sywhang
Copy link
Contributor

@sywhang sywhang commented Aug 30, 2022

We should export objectMarshalerPtr since it's exposed in a public
API - ObjectValues[T any, P objectMarshalerPtr[T]].

We should export objectMarshalerPtr since it's exposed in a public
API - ObjectValues[T any, P objectMarshalerPtr[T]].
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #1171 (1bf9a3b) into master (9abd14b) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1171      +/-   ##
==========================================
- Coverage   98.33%   98.24%   -0.10%     
==========================================
  Files          49       49              
  Lines        2165     2165              
==========================================
- Hits         2129     2127       -2     
- Misses         28       29       +1     
- Partials        8        9       +1     
Impacted Files Coverage Δ
array_go118.go 100.00% <ø> (ø)
zapcore/sampler.go 96.29% <0.00%> (-3.71%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sywhang sywhang merged commit 7681a0a into uber-go:master Aug 30, 2022
7 checks passed
@sywhang sywhang deleted the export-objectmarshalerptr branch August 30, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants