Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix deprecation docs and links #1193

Merged
merged 2 commits into from Oct 28, 2022

Conversation

sywhang
Copy link
Contributor

@sywhang sywhang commented Oct 28, 2022

Some of the doc comments on deprecated APIs weren't formatted correctly and wasn't showing up as deprecated on pkg.go.dev.

This fixes those incorrectly formatted docs. Also added links to point to the new APIs that deprecated them.

Some of the doc comments on deprecated APIs weren't formatted
correctly and wasn't showing up as deprecated on pkg.go.dev.

This fixes those incorrectly formatted docs. Also added links to
point to the new APIs that deprecated them.
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #1193 (ded5018) into master (9b86a50) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1193      +/-   ##
==========================================
+ Coverage   98.25%   98.34%   +0.09%     
==========================================
  Files          49       49              
  Lines        2180     2180              
==========================================
+ Hits         2142     2144       +2     
+ Misses         29       28       -1     
+ Partials        9        8       -1     
Impacted Files Coverage Δ
options.go 100.00% <ø> (ø)
zapcore/entry.go 92.77% <ø> (ø)
zapgrpc/zapgrpc.go 100.00% <ø> (ø)
zapcore/sampler.go 100.00% <0.00%> (+3.70%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sywhang sywhang merged commit da406e3 into uber-go:master Oct 28, 2022
7 checks passed
@sywhang sywhang deleted the chore/deprecations branch Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants