Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ReplaceAll instead of Replace with -1 pos arg #1195

Merged
merged 1 commit into from Nov 6, 2022

Conversation

sashamelentyev
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Merging #1195 (2a422d1) into master (da406e3) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1195      +/-   ##
==========================================
- Coverage   98.34%   98.25%   -0.10%     
==========================================
  Files          49       49              
  Lines        2180     2180              
==========================================
- Hits         2144     2142       -2     
- Misses         28       29       +1     
- Partials        8        9       +1     
Impacted Files Coverage Δ
zapcore/sampler.go 96.29% <0.00%> (-3.71%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sywhang
sywhang approved these changes Nov 6, 2022
Copy link
Contributor

@sywhang sywhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sywhang sywhang merged commit ed5598a into uber-go:master Nov 6, 2022
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants