Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IncreaseLevel being reset after With #812

Merged
merged 2 commits into from Apr 11, 2020
Merged

Fix IncreaseLevel being reset after With #812

merged 2 commits into from Apr 11, 2020

Conversation

prashantv
Copy link
Contributor

@prashantv prashantv commented Apr 3, 2020

Fixes #810

We missed implementing the increase-level logic in With
and since Core was embedded, we wended up using With from
the original core.

To avoid this sort of issue, avoid embedding and implement all
Core methods explicitly. This lets us consider the behaviour
of each method explicitly.

Fixes #810

We missed implementing the increase-level logic in With
and since Core was embedded, we wended up using With from
the original core.

To avoid this sort of issue, avoid embedding and implement all
Core methods explicitly. This lets us consider the behaviour
of each method explicitly.
@prashantv prashantv requested a review from abhinav Apr 3, 2020
@codecov
Copy link

@codecov codecov bot commented Apr 3, 2020

Codecov Report

Merging #812 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #812   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files          43       43           
  Lines        2315     2321    +6     
=======================================
+ Hits         2276     2282    +6     
  Misses         32       32           
  Partials        7        7           
Impacted Files Coverage Δ
zapcore/increase_level.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec2dc45...3ede7e8. Read the comment docs.

@prashantv prashantv merged commit c25a0c0 into master Apr 11, 2020
5 checks passed
@prashantv prashantv deleted the fix_with_level branch Apr 11, 2020
uvfive pushed a commit to bxsmart/zap that referenced this issue May 21, 2020
Fixes uber-go#810

We missed implementing the increase-level logic in With
and since Core was embedded, we wended up using With from
the original core.

To avoid this sort of issue, avoid embedding and implement all
Core methods explicitly. This lets us consider the behaviour
of each method explicitly.
cgxxv pushed a commit to cgxxv/zap that referenced this issue Mar 25, 2022
Fixes uber-go#810

We missed implementing the increase-level logic in With
and since Core was embedded, we wended up using With from
the original core.

To avoid this sort of issue, avoid embedding and implement all
Core methods explicitly. This lets us consider the behaviour
of each method explicitly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants