Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize if-condition #945

Merged
merged 1 commit into from May 18, 2021
Merged

Conversation

@tylitianrui
Copy link
Contributor

@tylitianrui tylitianrui commented May 17, 2021

No description provided.

@CLAassistant
Copy link

@CLAassistant CLAassistant commented May 17, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

@codecov codecov bot commented May 17, 2021

Codecov Report

Merging #945 (02e09ff) into master (7b21229) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #945   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files          44       44           
  Lines        1974     1974           
=======================================
  Hits         1940     1940           
  Misses         27       27           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b21229...02e09ff. Read the comment docs.

@abhinav abhinav merged commit debd2f1 into uber-go:master May 18, 2021
4 checks passed
4 checks passed
@travis-ci
Travis CI - Pull Request Build Passed
Details
@codecov
codecov/patch Coverage not affected when comparing 7b21229...02e09ff
Details
@codecov
codecov/project 98.27% (target 95.00%)
Details
license/cla Contributor License Agreement is signed.
Details
@abhinav
Copy link
Contributor

@abhinav abhinav commented May 18, 2021

Thanks!

abhinav added a commit that referenced this pull request May 25, 2021
Check for "both true" or "both false" is easily implemented as `x == y`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants