Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't panic in sweetenFields #949

Merged
merged 1 commit into from Jun 7, 2021

Conversation

atrn0
Copy link
Contributor

@atrn0 atrn0 commented May 22, 2021

Hello team 馃憢.
This PR fixes #896.

@CLAassistant
Copy link

CLAassistant commented May 22, 2021

CLA assistant check
All committers have signed the CLA.

@atrn0 atrn0 changed the title Don't Panic in sweetenFields Don't panic in sweetenFields May 22, 2021
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #949 (f54b4d3) into master (3748251) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #949   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files          44       44           
  Lines        1974     1974           
=======================================
  Hits         1935     1935           
  Misses         30       30           
  Partials        9        9           
Impacted Files Coverage 螖
sugar.go 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3748251...f54b4d3. Read the comment docs.

sywhang
sywhang approved these changes Jun 6, 2021
Copy link
Contributor

@sywhang sywhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤 This LGTM but I'd like to wait for @abhinav to go over it since he has more context on this issue.

abhinav
abhinav approved these changes Jun 7, 2021
Copy link
Contributor

@abhinav abhinav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@abhinav abhinav merged commit 084fb2a into uber-go:master Jun 7, 2021
5 checks passed
@atrn0 atrn0 deleted the not-dpanic-in-development branch Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Panic on wrong number of key value pairs
4 participants