Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: Check that 'go mod tidy' was run #951

Merged
merged 1 commit into from May 25, 2021
Merged

lint: Check that 'go mod tidy' was run #951

merged 1 commit into from May 25, 2021

Conversation

@abhinav
Copy link
Contributor

@abhinav abhinav commented May 25, 2021

In #948, we noticed that some go.sum files were outdated. To avoid
this in the future, add a lint check that verifies that go mod tidy
does not cause any changes.

This will fail with a dirty working tree as well, but in CI, we don't
expect that.

In #948, we noticed that some `go.sum` files were outdated. To avoid
this in the future, add a `lint` check that verifies that `go mod tidy`
does not cause any changes.

This will fail with a dirty working tree as well, but in CI, we don't
expect that.
@codecov
Copy link

@codecov codecov bot commented May 25, 2021

Codecov Report

Merging #951 (a2fca9d) into master (dedcdad) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #951      +/-   ##
==========================================
- Coverage   98.12%   98.02%   -0.11%     
==========================================
  Files          44       44              
  Lines        1975     1975              
==========================================
- Hits         1938     1936       -2     
- Misses         29       30       +1     
- Partials        8        9       +1     
Impacted Files Coverage Δ
zapcore/sampler.go 96.15% <0.00%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dedcdad...a2fca9d. Read the comment docs.

@abhinav abhinav merged commit fec3dad into master May 25, 2021
7 checks passed
7 checks passed
@github-actions
build (1.15.x)
Details
@github-actions
build (1.15.x)
Details
@github-actions
build (1.16.x)
Details
@github-actions
build (1.16.x)
Details
@codecov
codecov/patch Coverage not affected when comparing dedcdad...a2fca9d
Details
@codecov
codecov/project 98.02% (target 95.00%)
Details
license/cla Contributor License Agreement is signed.
Details
@abhinav abhinav deleted the make-tidy branch May 25, 2021
abhinav added a commit that referenced this pull request May 25, 2021
In #948, we noticed that some `go.sum` files were outdated. To avoid
this in the future, add a `lint` check that verifies that `go mod tidy`
does not cause any changes.

This will fail with a dirty working tree as well, but in CI, we don't
expect that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants