Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): make the layout stable #1795

Merged
merged 3 commits into from Aug 26, 2019
Merged

fix(docs): make the layout stable #1795

merged 3 commits into from Aug 26, 2019

Conversation

tajo
Copy link
Member

@tajo tajo commented Aug 26, 2019

Tiny layout changes:

  1. Table of contents (TOC) has now a correct width (unit was missing).
  2. The TOC position set to fixed so it always stays in the viewport and it also doesn't change the centering of the page. Going from a page like "Roadmap" to "Input" caused the page to jump.

And "Edit this page" goes to the actual edit UI which looks better than half broken MDX preview.

target="_blank"
size={SIZE.compact}
kind={KIND.tertiary}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't matter here but fyi - minimal and tertiary buttons are collapsed into the same style with the monochrome update

@gergelyke gergelyke merged commit 7761bde into master Aug 26, 2019
@baseui-probot-app-workflow baseui-probot-app-workflow bot deleted the layout-bits branch August 26, 2019 19:28
VladimirMilenko pushed a commit to VladimirMilenko/baseui that referenced this pull request Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants