Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTF API improvements #112

Merged
merged 3 commits into from Mar 7, 2019

Conversation

Projects
None yet
2 participants
@ibgreen
Copy link
Contributor

commented Mar 7, 2019

For #7 (Fixes #94)

This will be breaking change for v0.8 (Note: not breaking if using GLTFLoader, just GLTFParser).

Partial step for support for official Khronos Draco extension (fallback semantics not fully implemented).

ibgreen added some commits Mar 6, 2019

Show resolved Hide resolved docs/api-reference/gltf-loaders/gltf-loader.md Outdated
Show resolved Hide resolved docs/api-reference/gltf-loaders/gltf-parser.md Outdated

When parsed asynchronously (not using `loadSync` or `parseSync`):
* linked binary resources will be loaded and resolved (if url is available).
* base64 encoded binary data inside the JSON payload will be decodec

This comment has been minimized.

Copy link
@georgios-uber

georgios-uber Mar 7, 2019

Collaborator

decodec > decoded

Show resolved Hide resolved docs/api-reference/gltf-loaders/gltf-loader.md
Show resolved Hide resolved docs/whats-new.md Outdated
Show resolved Hide resolved modules/gltf/src/gltf/gltf-post-processor.js
@ibgreen
Copy link
Contributor Author

left a comment

Thanks, good catches!

Show resolved Hide resolved docs/api-reference/gltf-loaders/gltf-loader.md Outdated
Show resolved Hide resolved docs/api-reference/gltf-loaders/gltf-loader.md
Show resolved Hide resolved docs/api-reference/gltf-loaders/gltf-parser.md Outdated
Show resolved Hide resolved docs/whats-new.md Outdated
Show resolved Hide resolved modules/gltf/src/gltf/gltf-parser.js
Show resolved Hide resolved modules/gltf/src/gltf/gltf-post-processor.js

@ibgreen ibgreen merged commit 7ad5c93 into master Mar 7, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@ibgreen ibgreen deleted the ib/gltf-api branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.