Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core module cleanup - Phase 1 #119

Closed
wants to merge 4 commits into from

Conversation

Projects
None yet
2 participants
@ibgreen
Copy link
Contributor

ibgreen commented Mar 14, 2019

For #58

Background

  • core must be small
  • Fix bundle size analysis
  • Start identifying code that makes bundler add node.js polyfills (buffer, base64, browser,...) and eliminate the root causes.

@ibgreen ibgreen requested a review from Pessimistress Mar 14, 2019

@ibgreen ibgreen force-pushed the ib/core-image-cleanup branch from 13abbab to 9ad875e Mar 14, 2019

@ibgreen ibgreen force-pushed the ib/core-image-cleanup branch from 9ad875e to 5c079fd Mar 14, 2019

@@ -0,0 +1,236 @@
// Copyright (c) 2017 Uber Technologies, Inc.

This comment has been minimized.

Copy link
@Pessimistress

Pessimistress Mar 15, 2019

Contributor

Why are we adding this? All tests are using the root webpack.config.js now

@@ -0,0 +1,62 @@
#!/bin/sh

This comment has been minimized.

Copy link
@Pessimistress

Pessimistress Mar 15, 2019

Contributor

Contribute to ocular instead?

@Pessimistress

This comment has been minimized.

Copy link
Contributor

Pessimistress commented Mar 15, 2019

Try upgrade to the latest ocular-dev-tools to fix CI.

@ibgreen

This comment has been minimized.

Copy link
Contributor Author

ibgreen commented Apr 14, 2019

Most of this has been addressed in other PRs.

@ibgreen ibgreen closed this Apr 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.