Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API and test cleanup #124

Merged
merged 1 commit into from Mar 18, 2019

Conversation

Projects
None yet
3 participants
@ibgreen
Copy link
Contributor

ibgreen commented Mar 18, 2019

For #58

Changes

  • Light cleanup pass on docs
  • Modernize test loading of files
  • Improve the experimental async iterator and batched loading API
@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 18, 2019

Coverage Status

Coverage increased (+0.8%) to 24.685% when pulling 787e42a on ib/lib-improvements into f3b4319 on master.

@ibgreen ibgreen requested a review from Pessimistress Mar 18, 2019

@ibgreen ibgreen merged commit e5424cc into master Mar 18, 2019

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.8%) to 24.685%
Details
license/cla Contributor License Agreement is signed.
Details

@ibgreen ibgreen deleted the ib/lib-improvements branch Mar 18, 2019

- `Iterator` -
- `AsyncIterator` -
- `ReadableStream` -
- `Promise` - A promise will be resolved and if result

This comment has been minimized.

Copy link
@Pessimistress

Pessimistress Mar 18, 2019

Contributor

Unfinished?

import {getGLTFIndices, getGLTFAccessors, getGLTFAttributeMap} from '@loaders.gl/core';

/*
const PATTERNS = [

This comment has been minimized.

Copy link
@Pessimistress

Pessimistress Mar 18, 2019

Contributor

Remove?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.