Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gltf attribute name map #130

Merged
merged 3 commits into from Mar 25, 2019

Conversation

Projects
None yet
3 participants
@ibgreen
Copy link
Contributor

ibgreen commented Mar 24, 2019

  • Just map to glTF attribute names directly
  • Will be accompanied by support for glTF names in luma.gl

@ibgreen ibgreen requested a review from Pessimistress Mar 24, 2019

@ibgreen ibgreen marked this pull request as ready for review Mar 24, 2019

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 24, 2019

Coverage Status

Coverage decreased (-0.06%) to 26.831% when pulling 57605c9 on ib/mesh-gltf-attribute-names into 63a4765 on master.

@Pessimistress
Copy link
Contributor

Pessimistress left a comment

Much cleaner!

@ibgreen ibgreen merged commit cf8423a into master Mar 25, 2019

3 of 4 checks passed

coverage/coveralls Coverage decreased (-0.06%) to 26.831%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@ibgreen ibgreen deleted the ib/mesh-gltf-attribute-names branch Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.