Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ocular-dev-tools #45

Merged
merged 4 commits into from Mar 7, 2019

Conversation

Projects
None yet
3 participants
@Pessimistress
Copy link
Contributor

Pessimistress commented Mar 7, 2019

No description provided.

@Pessimistress Pessimistress requested review from tsherif and ibgreen Mar 7, 2019

@Pessimistress Pessimistress force-pushed the upgrade-dev-tools branch from ddf3b94 to beff6f3 Mar 7, 2019

@tsherif

tsherif approved these changes Mar 7, 2019

@ibgreen

ibgreen approved these changes Mar 7, 2019

entry: {
'test-node': 'test/index.js',
size: {
all: 'test/size/all.js',

This comment has been minimized.

Copy link
@ibgreen

ibgreen Mar 7, 2019

Contributor

At some point in the future, we could just scan the top level export for symbols and auto generate these.

"cover": "NODE_ENV=test nyc --reporter html --reporter cobertura --reporter=lcov npm run test-cover",
"test-cover": "NODE_ENV=test tape -r babel-register test/node.js && nyc report",
"test-browser": "webpack-dev-server --config test/webpack.config.js --env.test --progress --hot --open"
"publish-prod": "ocular-publish prod",

This comment has been minimized.

Copy link
@ibgreen

ibgreen Mar 7, 2019

Contributor

Future: Have just one publish and have ocular-publish fail if no arg given?

Show resolved Hide resolved test/bench/browser.js Outdated
Show resolved Hide resolved test/bench/node.js

Pessimistress added some commits Mar 7, 2019

@Pessimistress Pessimistress merged commit a75a513 into master Mar 7, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@Pessimistress Pessimistress deleted the upgrade-dev-tools branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.