From 29902bee3deeb430ac5e33bad6d58512628427b9 Mon Sep 17 00:00:00 2001 From: Manu Sridharan Date: Thu, 24 Aug 2023 09:14:27 -0700 Subject: [PATCH] add comment --- nullaway/src/main/java/com/uber/nullaway/ErrorBuilder.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/nullaway/src/main/java/com/uber/nullaway/ErrorBuilder.java b/nullaway/src/main/java/com/uber/nullaway/ErrorBuilder.java index 28ef27c9a7..2e97588932 100755 --- a/nullaway/src/main/java/com/uber/nullaway/ErrorBuilder.java +++ b/nullaway/src/main/java/com/uber/nullaway/ErrorBuilder.java @@ -203,6 +203,9 @@ private Description.Builder addSuggestedSuppression( if (config.getCastToNonNullMethod() != null && canBeCastToNonNull(suggestTree)) { builder = addCastToNonNullFix(suggestTree, builder); } else { + // When there is a castToNonNull method, suggestTree is set to the expression to be + // casted, which is not suppressible. For simplicity, we just always recompute the + // suppressible node here. Tree suppressibleNode = suppressibleNode(state.getPath()); if (suppressibleNode != null) { builder = addSuppressWarningsFix(suppressibleNode, builder, suppressionName);