Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(yard): make it visible that props are hoverable #2266

Merged
merged 4 commits into from Nov 8, 2019

Conversation

@gergelyke
Copy link
Collaborator

gergelyke commented Nov 7, 2019

No description provided.

@gergelyke gergelyke added the docs label Nov 7, 2019
@now

This comment has been minimized.

Copy link

now bot commented Nov 7, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/uber-ui-platform/baseweb/7fhxw21id
🌍 Preview: https://baseweb-git-docs-props-hoverable.uber-ui-platform.now.sh

Copy link
Collaborator

chasestarr left a comment

I'm fine with testing out this icon, but I do feel it's a bit overwhelming to see it all over the place. Once a website visitor uses the feature once, the know it forever. Not sure if something more subtle is appropriate like an underline

@sandgraham

This comment has been minimized.

Copy link
Collaborator

sandgraham commented Nov 8, 2019

i think i agree with using an underline like @chasestarr suggested. i can't really make out the question mark in the circle- but then again i'm not wearing my glasses.

@now now bot temporarily deployed to staging Nov 8, 2019 Inactive
@gergelyke

This comment has been minimized.

Copy link
Collaborator Author

gergelyke commented Nov 8, 2019

@chasestarr @sandgraham makes perfect sense, just updated the PR

@gergelyke gergelyke merged commit 7d41adc into master Nov 8, 2019
22 checks passed
22 checks passed
greeting
Details
buildkite/baseweb Build #12886 passed (9 minutes, 19 seconds)
Details
buildkite/baseweb/deploy Passed (15 seconds)
Details
buildkite/baseweb/docker-package-e2e Passed (1 minute, 50 seconds)
Details
buildkite/baseweb/docker-package-unit Passed (58 seconds)
Details
buildkite/baseweb/documentation-site-link-checker Passed (1 minute, 38 seconds)
Details
buildkite/baseweb/e2e Passed (1 minute, 5 seconds)
Details
buildkite/baseweb/eslint Passed (43 seconds)
Details
buildkite/baseweb/flowtype Passed (39 seconds)
Details
buildkite/baseweb/fossa Passed (1 minute, 1 second)
Details
buildkite/baseweb/guard-component-sizes Passed (1 minute, 6 seconds)
Details
buildkite/baseweb/jest Passed (34 seconds)
Details
buildkite/baseweb/pipeline Passed (9 seconds)
Details
buildkite/baseweb/typescript Passed (20 seconds)
Details
buildkite/baseweb/validate-examples Passed (12 seconds)
Details
buildkite/baseweb/vrt Passed (7 minutes, 12 seconds)
Details
ci-gate Pull Request accepted for CI
license/cla Contributor License Agreement is signed.
Details
now Deployment has completed
Details
probot/migrations Migration guide provided
probot/pr-label At least one required semver-related label exists
probot/todos All TODOs have open issues
@uber-baseweb-probots uber-baseweb-probots bot deleted the docs/props-hoverable branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.