Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: creator.js refactor #2326

Closed
wants to merge 1 commit into from
Closed

Conversation

ODAVING
Copy link

@ODAVING ODAVING commented Nov 15, 2019

Fixes #2318

Description

breaking
color-deprecated-semantic-tokens.js added, zIndex rmv & primitives made optional in creator.js
I haven't fully removed the semantic colors, as there was nothing under the comment on line 118 in creator.js. However I copied everything that included a primitive color under semantics commented in the color-deprecated-semantic-tokens.js so if you could kindly clarify this, that'd be amazing.

Scope

  • Patch: Bug Fix
  • Minor: New Feature
  • Major: Breaking Change

color-deprecated-semantic-tokens.js added, zIndex rmv & primitives optn

fixes #2318
@vercel
Copy link

vercel bot commented Nov 15, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ODAVING ODAVING changed the title [theme]: creator.js refactor Breaking: creator.js refactor Nov 15, 2019
@ODAVING ODAVING changed the title Breaking: creator.js refactor breaking: creator.js refactor Nov 15, 2019
@nadiia
Copy link
Contributor

nadiia commented Nov 16, 2019

Hi @ODAVING, thank you for contributing. The ticket #2318 was created based on the pending PR #2316 that refactors theme. The added color-deprecated-semantic-tokens.js in that PR would need to be removed in the next major version in favor of semantic tokens that currently added under /tokens/light-theme-color-semantic.js and /tokens/dark-theme-color-semantic.js. There is no plan to release a major upgrade soon so I'd like to put this change on hold for now.

@nadiia nadiia closed this Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants