New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added aria label prop and attribute to checkbox #3906
Conversation
@mattcfilbert is attempting to deploy a commit to the Uber UI Platform Team on Vercel. A member of the Team first needs to authorize it. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3430922:
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/uber-ui-platform/baseweb/cnlczvlqe |
missing in flow types (failing CI now) and should be added to |
Thank you for your feedback @tajo - as was apparent, I am a new contributor and am happy to learn the proper pattern. Is there anything else that I need to do to make buildkite run? I believe I made the necessary code changes, but see that the build is blocked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank You
Fixes #3905
Description
Added a single attribute and prop to the checkbox component to allow an aria-label to be used. This will allow greater accessibility for the component as the title attribute is not consistently reliable for all screen readers. (Discovered while getting my 508 accessibility training while working on an app using BaseUI as primary component library.)
Scope
Minor: New Feature