From 008c622db054c2f1550e7c3a7512b8a6f1c2cf22 Mon Sep 17 00:00:00 2001 From: Abhishek Jha Date: Tue, 7 May 2024 22:31:35 -0700 Subject: [PATCH] After review --- common/domain/dlq_message_handler_test.go | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/common/domain/dlq_message_handler_test.go b/common/domain/dlq_message_handler_test.go index 91deb69a14..a6eaf836a9 100644 --- a/common/domain/dlq_message_handler_test.go +++ b/common/domain/dlq_message_handler_test.go @@ -138,8 +138,6 @@ func TestDLQMessageHandler_Start(t *testing.T) { for _, tc := range tests { t.Run(tc.name, func(t *testing.T) { ctrl := gomock.NewController(t) - defer ctrl.Finish() - mockQueue := NewMockReplicationQueue(ctrl) mockReplicationTaskExecutor := NewMockReplicationTaskExecutor(ctrl) mockLogger := testlogger.New(t) @@ -160,7 +158,7 @@ func TestDLQMessageHandler_Start(t *testing.T) { handler.Start() mockedTime.Advance(5 * time.Minute) defer handler.Stop() - assert.Equal(t, tc.expectedStatus, atomic.LoadInt32(&handler.status), assert.Equal(t, tc.expectedStatus, atomic.LoadInt32(&handler.status), "Handler did not reach the expected status for test case: %s", tc.name)) + assert.Equal(t, tc.expectedStatus, atomic.LoadInt32(&handler.status)) }) } } @@ -190,9 +188,6 @@ func (s *dlqMessageHandlerSuite) TestStop() { s.Run(test.name, func() { atomic.StoreInt32(&s.dlqMessageHandler.status, test.initialStatus) s.dlqMessageHandler.Stop() - if test.shouldStop { - s.dlqMessageHandler.logger.Info("Domain DLQ handler shutting down.") - } s.Equal(test.expectedStatus, atomic.LoadInt32(&s.dlqMessageHandler.status)) }) }