Skip to content

Commit

Permalink
use object as parameter
Browse files Browse the repository at this point in the history
  • Loading branch information
jianhuang01 committed Apr 11, 2019
1 parent d76524d commit b0665f4
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion modules/core/src/effects/lighting/camera-light.js
Expand Up @@ -2,7 +2,7 @@ import PointLight from './point-light';
import {getUniformsFromViewport} from '../../shaderlib/project/viewport-uniforms';

export default class CameraLight extends PointLight {
getProjectedLight(layer) {
getProjectedLight({layer}) {
const viewport = layer.context.viewport;
const {coordinateSystem, coordinateOrigin, modelMatrix} = layer.props;
const {project_uCameraPosition} = getUniformsFromViewport({
Expand Down
4 changes: 2 additions & 2 deletions modules/core/src/effects/lighting/lighting-effect.js
Expand Up @@ -69,7 +69,7 @@ export default class LightingEffect extends Effect {

for (let i = 0; i < this.pointLights.length; i++) {
const pointLight = this.pointLights[i];
projectedPointLights.push(pointLight.getProjectedLight(layer));
projectedPointLights.push(pointLight.getProjectedLight({layer}));
}
return projectedPointLights;
}
Expand All @@ -79,7 +79,7 @@ export default class LightingEffect extends Effect {

for (let i = 0; i < this.directionalLights.length; i++) {
const directionalLight = this.directionalLights[i];
projectedDirectionalLights.push(directionalLight.getProjectedLight(layer));
projectedDirectionalLights.push(directionalLight.getProjectedLight({layer}));
}
return projectedDirectionalLights;
}
Expand Down
2 changes: 1 addition & 1 deletion modules/core/src/effects/lighting/point-light.js
Expand Up @@ -8,7 +8,7 @@ export default class PointLight extends BasePointLight {
this.projectedLight = new BasePointLight(props);
}

getProjectedLight(layer) {
getProjectedLight({layer}) {
const viewport = layer.context.viewport;
const {coordinateSystem, coordinateOrigin} = layer.props;
const position = projectPosition(this.position, {
Expand Down

0 comments on commit b0665f4

Please sign in to comment.