Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default lighting and material #2749

merged 1 commit into from Mar 5, 2019


None yet
3 participants
Copy link

jianhuang01 commented Mar 4, 2019

For #2096


Change List

  • add default light sources
  • add default material prop
  • update render tests

@jianhuang01 jianhuang01 merged commit f78c55e into master Mar 5, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
license/cla Contributor License Agreement is signed.

@jianhuang01 jianhuang01 deleted the add-default-lighting branch Mar 5, 2019

@@ -1,4 +1,5 @@
import {deepEqual} from '../utils/deep-equal';
import {default as LightingEffect} from '../effects/lighting-effect';

This comment has been minimized.

Copy link

ibgreen Mar 5, 2019


I think it would be better that the instantiator of the EffectManager (i.e. Deck) would choose to add this default Effect, rather than the EffectManager always including it.

This comment has been minimized.

Copy link

jianhuang01 Mar 5, 2019

Author Contributor

The setProps in Deck is already pretty messy, better only manage things in high level, that's why I preferred to avoid extra effect checking and adding logic in Deck.

ajduberstein added a commit to ajduberstein/ that referenced this pull request Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.