Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lightSettings prop in examples and website #2755

Merged
merged 2 commits into from Mar 5, 2019

Conversation

Projects
None yet
2 participants
@jianhuang01
Copy link
Contributor

jianhuang01 commented Mar 5, 2019

For #2096

Change List

  • remove lightSettings prop
  • update probe.gl version to avoid crash
  • fix wrong contour layer import

@jianhuang01 jianhuang01 added the code label Mar 5, 2019

@jianhuang01 jianhuang01 requested review from tsherif, Pessimistress and ibgreen Mar 5, 2019

@jianhuang01 jianhuang01 changed the title Remove lightSetting prop in examples and website Remove lightSettings prop in examples and website Mar 5, 2019

@ibgreen

ibgreen approved these changes Mar 5, 2019

@jianhuang01 jianhuang01 merged commit ab12e5d into master Mar 5, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@jianhuang01 jianhuang01 deleted the remove-light-setting branch Mar 5, 2019

ajduberstein added a commit to ajduberstein/deck.gl that referenced this pull request Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.