Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change point light class import name #2756

Merged
merged 1 commit into from Mar 5, 2019

Conversation

Projects
None yet
2 participants
@jianhuang01
Copy link
Contributor

jianhuang01 commented Mar 5, 2019

For #2096

Background

Planned to have a PointLight class in deck.gl with coordinate information, found which is not necessary, change the import name back.

Change List

  • fix point light class import name

@jianhuang01 jianhuang01 added the code label Mar 5, 2019

@jianhuang01 jianhuang01 requested review from Pessimistress and ibgreen Mar 5, 2019

@ibgreen

ibgreen approved these changes Mar 5, 2019

Copy link
Contributor

ibgreen left a comment

\o/ Warmly approved!

@jianhuang01 jianhuang01 merged commit b3066a0 into master Mar 5, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@jianhuang01 jianhuang01 deleted the fix-light-name branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.