Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor mesh-layers model matrix #2778

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
5 participants
@georgios-uber
Copy link
Contributor

georgios-uber commented Mar 11, 2019

No description provided.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 11, 2019

Coverage Status

Coverage increased (+0.2%) to 57.03% when pulling 5ca841b on refact-model-matrix into 02d8995 on master.

@ibgreen
Copy link
Contributor

ibgreen left a comment

Makes a lot of sense.

Agree with 90% of the changes, though per my tastes, I think the push of shared code to utils went little bit too far in two places. It is sometimes better to keep a few things "up top" for readability, even though it leaves us with slightly bigger code.

Show resolved Hide resolved modules/mesh-layers/src/utils/matrix.js Outdated
Show resolved Hide resolved modules/mesh-layers/src/utils/matrix.js Outdated
Show resolved Hide resolved modules/mesh-layers/src/scenegraph-layer/scenegraph-layer.js Outdated
Show resolved Hide resolved modules/mesh-layers/src/utils/matrix.js Outdated

@ibgreen ibgreen requested a review from Pessimistress Mar 11, 2019

@georgios-uber georgios-uber force-pushed the refact-model-matrix branch from f517b24 to 5ca841b Mar 11, 2019

@georgios-uber georgios-uber requested a review from jianhuang01 Mar 11, 2019

@georgios-uber georgios-uber merged commit df74327 into master Mar 11, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@georgios-uber georgios-uber deleted the refact-model-matrix branch Mar 11, 2019

ajduberstein added a commit to ajduberstein/deck.gl that referenced this pull request Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.