Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating small objects when checking redraw flags #2785

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
4 participants
@Pessimistress
Copy link
Contributor

Pessimistress commented Mar 12, 2019

Change List

  • avoid recursively creating small objects in deck.needsRedraw
  • all clearRedrawFlags are now default to false

@Pessimistress Pessimistress requested review from tsherif and ibgreen Mar 12, 2019

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 12, 2019

Coverage Status

Coverage increased (+0.02%) to 58.803% when pulling a4e7e8f on redraw-cleanup into 307b847 on master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 12, 2019

Coverage Status

Coverage increased (+0.02%) to 58.803% when pulling a4e7e8f on redraw-cleanup into 307b847 on master.

@ibgreen
Copy link
Contributor

ibgreen left a comment

I am not sure how documented this system is in deck.gl (assume you have scanned docs) but the deck method seems like it could/should be documented?

The changed default value is perhaps worth a brief bullet in upgrade guide?

I believe there is similar handling in luma.gl which should follow suit?

@Pessimistress Pessimistress merged commit 9929e1b into master Mar 13, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@Pessimistress Pessimistress deleted the redraw-cleanup branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.