Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish dev (unminified) scripts #2788

Merged
merged 4 commits into from Mar 13, 2019

Conversation

Projects
None yet
3 participants
@ibgreen
Copy link
Contributor

ibgreen commented Mar 12, 2019

For #2787

Background

Change List

  • Additional script build target

ibgreen added some commits Mar 12, 2019

@ibgreen ibgreen requested a review from Pessimistress Mar 12, 2019

@ibgreen

This comment has been minimized.

Copy link
Contributor Author

ibgreen commented Mar 12, 2019

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 12, 2019

Coverage Status

Coverage increased (+0.02%) to 58.803% when pulling 493bd9d on ib/add-dev-scripts into 307b847 on master.

@@ -0,0 +1,14 @@
const config = module.require('./bundle.config');

This comment has been minimized.

Copy link
@Pessimistress

Pessimistress Mar 13, 2019

Contributor

Use an --env.dev flag instead of creating a new config file?

Then the submodule scripts can look like:

"build-bundle": "webpack --config ../../scripts/bundle.config.js",
"prepublishOnly": "npm run build-bundle && npm run build-bundle --env.dev"

This comment has been minimized.

Copy link
@ibgreen

ibgreen Mar 13, 2019

Author Contributor

Done. FWIW, to pass the arguments on to webpack an extra -- is needed

`npm run build-bundle -- --env.dev"

config.mode = 'development';

// Remove .min from the name
config.output.filename = 'dist.js';

This comment has been minimized.

Copy link
@Pessimistress

Pessimistress Mar 13, 2019

Contributor

dist.js is not included by files in package.jsons

@@ -27,7 +27,7 @@
"sideEffects": false,
"scripts": {
"build-bundle": "webpack --config ../../scripts/bundle.config.js",
"prepublishOnly": "npm run build-bundle"
"prepublishOnly": "npm run build-bundle && npm run build-bundle -- --env.dev"

This comment has been minimized.

Copy link
@Pessimistress

Pessimistress Mar 13, 2019

Contributor

This file is missing files field updates

@ibgreen ibgreen merged commit d15b248 into master Mar 13, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@ibgreen ibgreen deleted the ib/add-dev-scripts branch Mar 13, 2019

@ibgreen

This comment has been minimized.

Copy link
Contributor Author

ibgreen commented Mar 13, 2019

This file is missing files field updates

Fixed but final push failed, didn't notice will open new PR.

ajduberstein added a commit to ajduberstein/deck.gl that referenced this pull request Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.