Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IconLayer autopacking: generate mipmap when constructing Texture #2790

Merged
merged 2 commits into from Mar 14, 2019

Conversation

Projects
None yet
3 participants
@xintongxia
Copy link
Contributor

commented Mar 13, 2019

For #2745

@xintongxia xintongxia requested a review from Pessimistress Mar 13, 2019

@coveralls

This comment has been minimized.

Copy link

commented Mar 13, 2019

Coverage Status

Coverage remained the same at 58.78% when pulling a827c21 on xx/fix-icon-mipmap into 307b847 on master.

@coveralls

This comment has been minimized.

Copy link

commented Mar 13, 2019

Coverage Status

Coverage decreased (-0.04%) to 58.739% when pulling 6ecb1dc on xx/fix-icon-mipmap into 307b847 on master.

@@ -278,7 +278,11 @@ export default class IconManager {
if (!this._texture) {
this._texture = new Texture2D(this.gl, {
width: this._canvasWidth,
height: this._canvasHeight
height: this._canvasHeight,
parameters: {

This comment has been minimized.

Copy link
@Pessimistress

Pessimistress Mar 13, 2019

Contributor

Make default texture parameters a constant that is shared between pre-packed and auto-packed

@xintongxia xintongxia merged commit cde9e78 into master Mar 14, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@xintongxia xintongxia deleted the xx/fix-icon-mipmap branch Mar 14, 2019

ajduberstein added a commit to ajduberstein/deck.gl that referenced this pull request Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.