Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Prop Animation (PR 1/4) #2791

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@Pessimistress
Copy link
Contributor

commented Mar 13, 2019

For #2363

Change List

  • Add LayerPropAnimation class
  • Tests

Pessimistress added some commits Mar 13, 2019

@Pessimistress Pessimistress requested review from tsherif and ibgreen Mar 13, 2019

@coveralls

This comment has been minimized.

Copy link

commented Mar 13, 2019

Coverage Status

Coverage increased (+0.3%) to 59.102% when pulling 9b3a1ec on animation-1 into 9929e1b on master.

case 'array':
if (
startValue.length === endValue.length &&
startValue.length <= 16 &&

This comment has been minimized.

Copy link
@jianhuang01

jianhuang01 Mar 13, 2019

Contributor

better to add comment to explain why we use 16 here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.