Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Prop Animation (PR 2/4) #2792

Open
wants to merge 1 commit into
base: animation-1
from

Conversation

Projects
None yet
3 participants
@Pessimistress
Copy link
Contributor

commented Mar 13, 2019

For #2363

Change List

  • Handle LayerPropAnimation in prop creation
  • Check animation states in layerManager.needsUpdate
  • Update animation props in layer._initialize and layer._update
  • Use prop animation in heatmap example

@Pessimistress Pessimistress requested review from tsherif and ibgreen Mar 13, 2019

@coveralls

This comment has been minimized.

Copy link

commented Mar 13, 2019

Coverage Status

Coverage decreased (-0.06%) to 59.02% when pulling 4d4e186 on animation-2 into 9b3a1ec on animation-1.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented Mar 13, 2019

Coverage Status

Coverage decreased (-0.06%) to 59.02% when pulling 4d4e186 on animation-2 into 9b3a1ec on animation-1.

@@ -99,7 +52,7 @@ export class App extends Component {
coverage,
data,
elevationRange: [0, 3000],
elevationScale: this.state.elevationScale,
elevationScale: data ? new LayerPropAnimation(0).to({value: 50, duration: 2000}) : 0,

This comment has been minimized.

Copy link
@jianhuang01

jianhuang01 Mar 13, 2019

Contributor

do we need this if statement here? won't do anything anyway when data is null

@@ -558,6 +565,7 @@ export default class Layer extends Component {
// initializeState callback tends to clear state
this.setChangeFlags({dataChanged: true, propsChanged: true, viewportChanged: true});

this._updateAnimationProps();

This comment has been minimized.

Copy link
@jianhuang01

jianhuang01 Mar 13, 2019

Contributor

kind of confusing here, we claim to check if needs updating here, but actually does the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.