Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve grid aggregation perf #2794

Merged
merged 2 commits into from Mar 13, 2019

Conversation

Projects
None yet
4 participants
@Pessimistress
Copy link
Contributor

commented Mar 13, 2019

Change List

  • Avoid using Array.push, pre-allocate typed arrays
  • Remove excessive asserts

Pessimistress added some commits Mar 13, 2019

@Pessimistress Pessimistress requested a review from jianhuang01 Mar 13, 2019

@coveralls

This comment has been minimized.

Copy link

commented Mar 13, 2019

Coverage Status

Coverage increased (+0.02%) to 58.715% when pulling 1e3bbba on screen-grid-layer into 789dc04 on master.

@tsherif

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

This looks fantastic! Any info on the difference it made?

@Pessimistress

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2019

@tsherif Testing with the website dataset (570k):
Old: 588ms
New: 46ms

@Pessimistress Pessimistress merged commit 39cc20d into master Mar 13, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@Pessimistress Pessimistress deleted the screen-grid-layer branch Mar 13, 2019

@tsherif

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

Yes! 💯

ajduberstein added a commit to ajduberstein/deck.gl that referenced this pull request Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.