Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TileLayer API audit #2799

Merged
merged 6 commits into from Mar 19, 2019

Conversation

Projects
None yet
3 participants
@xintongxia
Copy link
Contributor

xintongxia commented Mar 15, 2019

Background

deck.gl v7.0 Layers API Audit

Change List

  • onDataLoaded: Rename to onTileLoaded
  • onGetTileDataError: Rename to onTileError
  • add test

@xintongxia xintongxia requested a review from Pessimistress Mar 15, 2019

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 15, 2019

Coverage Status

Coverage increased (+0.3%) to 58.782% when pulling 5d93db4 on xx/tile-layer into eae5ed0 on master.

Show resolved Hide resolved docs/layers/tile-layer.md Outdated
Show resolved Hide resolved docs/layers/tile-layer.md Outdated
Show resolved Hide resolved examples/experimental/bezier/src/sample-graph.json Outdated
Show resolved Hide resolved modules/geo-layers/src/tile-layer/tile-layer.js Outdated
Show resolved Hide resolved modules/geo-layers/src/tile-layer/tile-layer.js Outdated

@xintongxia xintongxia merged commit ffee0e8 into master Mar 19, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@xintongxia xintongxia deleted the xx/tile-layer branch Mar 19, 2019

ajduberstein added a commit to ajduberstein/deck.gl that referenced this pull request Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.