Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate phong light module with new name #2806

merged 1 commit into from Mar 15, 2019


None yet
4 participants
Copy link

commented Mar 15, 2019

For #2096

Change List

  • integrate with module with new name

This comment has been minimized.

Copy link

commented Mar 15, 2019

Coverage Status

Coverage remained the same at 58.496% when pulling 149657f on integrate-new-lights into eae5ed0 on master.

@jianhuang01 jianhuang01 merged commit 0543db7 into master Mar 15, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
license/cla Contributor License Agreement is signed.

@jianhuang01 jianhuang01 deleted the integrate-new-lights branch Mar 15, 2019

@@ -19,17 +19,17 @@

import {registerShaderModules, setDefaultShaderModules} from '';
import {fp32, fp64, picking, phonglighting as lighting} from '';
import {fp32, fp64, picking, phonglighting} from '';

This comment has been minimized.

Copy link

ibgreen Mar 16, 2019


Other modules use camelCase: phongLighting for identifiers matching hyphenated words. Please follow unless good reason not to.

ajduberstein added a commit to ajduberstein/ that referenced this pull request Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.