Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TileLayer: add embed demo example #2814

Merged
merged 1 commit into from Mar 22, 2019

Conversation

Projects
None yet
3 participants
@xintongxia
Copy link
Contributor

xintongxia commented Mar 20, 2019

Background

v7.0 API audit

Change List

  • tile-layer.md
  • website demo

Screen Shot 2019-03-20 at 11 39 17 AM

@xintongxia xintongxia requested a review from Pessimistress Mar 20, 2019

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 20, 2019

Coverage Status

Coverage remained the same at 58.959% when pulling a9ac685 on xx/tile-layer into a219ac2 on master.

@Pessimistress
Copy link
Contributor

Pessimistress left a comment

Screenshot?

Show resolved Hide resolved docs/layers/tile-layer.md Outdated
@Pessimistress

This comment has been minimized.

Copy link
Contributor

Pessimistress commented Mar 21, 2019

Set opacity to 1 to avoid the artifact at tile edges.

TileLayer: add embed demo example
Allow missing data field in website demo example

fix typo

set opacity to 1

@xintongxia xintongxia force-pushed the xx/tile-layer branch from 36a89ea to a9ac685 Mar 21, 2019

@xintongxia xintongxia merged commit 76291a0 into master Mar 22, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@xintongxia xintongxia deleted the xx/tile-layer branch Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.