Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve S2Layer accuracy & docs #2819

Merged
merged 4 commits into from Mar 22, 2019

Conversation

Projects
None yet
4 participants
@Pessimistress
Copy link
Contributor

commented Mar 21, 2019

Before:
image

After:
image

Change List

  • Generate curve at lower levels
  • Correct props documentation

@Pessimistress Pessimistress requested review from ibgreen and urosi2453 Mar 21, 2019

for (let j = 0; j < resolution; j++) {
offset[0] += stepI;
offset[1] += stepJ;
const st = S2.IJToST(ij, level, offset);

This comment has been minimized.

Copy link
@ibgreen

ibgreen Mar 21, 2019

Contributor

Maybe briefly explain IJ ST etc?

@ibgreen
Copy link
Contributor

left a comment

Just an idea: the images were very helpful, I think it could be really nice to include them in the doc (maybe in smaller format) to explain how the resolution thing works.

In general we want more images in the docs...

@Pessimistress Pessimistress force-pushed the s2-layer branch from 598dea1 to 77bfa54 Mar 22, 2019

@coveralls

This comment has been minimized.

Copy link

commented Mar 22, 2019

Coverage Status

Coverage increased (+0.04%) to 58.997% when pulling 77bfa54 on s2-layer into 76291a0 on master.

@Pessimistress Pessimistress merged commit a03c7e0 into master Mar 22, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@Pessimistress Pessimistress deleted the s2-layer branch Apr 1, 2019

ajduberstein added a commit to ajduberstein/deck.gl that referenced this pull request Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.