Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GreatCircleLayer Fixes #2820

Merged
merged 3 commits into from Mar 21, 2019

Conversation

Projects
None yet
2 participants
@Pessimistress
Copy link
Contributor

commented Mar 21, 2019

Change List

  • Update vertex shader to match the new ArcLayer API
  • Add documentation
  • Tests

@Pessimistress Pessimistress requested a review from xintongxia Mar 21, 2019

sin(delta.x / 2.0) * sin(delta.x / 2.0);
return 2.0 * atan(sqrt(a), sqrt(1.0 - a));
sin_half_delta.x * sin_half_delta.x;
return 2.0 * atan(sqrt(a), sqrt(1.0 - a));

This comment has been minimized.

Copy link
@xintongxia

xintongxia Mar 21, 2019

Contributor

format

float x = a * cos_source.y * cos_source.x + b * cos_target.y * cos_target.x;
float y = a * cos_source.y * sin_source.x + b * cos_target.y * sin_target.x;
float z = a * sin_source.y + b * sin_target.y;

This comment has been minimized.

Copy link
@xintongxia

xintongxia Mar 21, 2019

Contributor

Line 77 - 84 indent not correct

This comment has been minimized.

Copy link
@Pessimistress

Pessimistress Mar 21, 2019

Author Contributor

It's just github formatting tabs weirdly

sin(delta.x / 2.0) * sin(delta.x / 2.0);
return 2.0 * atan(sqrt(a), sqrt(1.0 - a));
sin_half_delta.x * sin_half_delta.x;
return 2.0 * atan(sqrt(a), sqrt(1.0 - a));
}
vec2 interpolate (vec2 source, vec2 target, float angularDist, float t) {

This comment has been minimized.

Copy link
@xintongxia

xintongxia Mar 21, 2019

Contributor

Maybe link to a page to explain about the spherical interpolation.

@Pessimistress Pessimistress merged commit 27a083a into master Mar 21, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@Pessimistress Pessimistress deleted the great-circle-layer branch Mar 21, 2019

ajduberstein added a commit to ajduberstein/deck.gl that referenced this pull request Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.