Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenStreetMap example using TileLayer and BitmapLayer #2821

Merged
merged 3 commits into from Mar 25, 2019

Conversation

Projects
None yet
5 participants
@xintongxia
Copy link
Contributor

commented Mar 21, 2019

For #2802

Change List

  • example
    openstreet

@xintongxia xintongxia requested a review from Pessimistress Mar 21, 2019

@Pessimistress

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

Add a screenshot/GIF for review.

@xintongxia xintongxia force-pushed the xx/tile-bitmap branch from fdcf7b5 to bbf392e Mar 22, 2019

@coveralls

This comment has been minimized.

Copy link

commented Mar 22, 2019

Coverage Status

Coverage increased (+0.04%) to 60.123% when pulling d45ec7e on xx/tile-bitmap into 61340ab on master.

Show resolved Hide resolved examples/website/openstreet-map/app.js Outdated
Show resolved Hide resolved examples/website/openstreet-map/app.js Outdated
Show resolved Hide resolved examples/website/openstreet-map/index.html
Show resolved Hide resolved examples/website/openstreet-map/package.json Outdated
this.setState({
bitmapTexture: new Texture2D(gl, {
data,
parameters: DEFAULT_TEXTURE_PARAMETERS

This comment has been minimized.

Copy link
@Pessimistress

Pessimistress Mar 22, 2019

Contributor

Does this help the image quality?

This comment has been minimized.

Copy link
@xintongxia

xintongxia Mar 23, 2019

Author Contributor

Not really. It looks the same with or without these parameters.

xintongxia added some commits Mar 21, 2019

Add OpenStreetMap example using TileLayer and BitmapLayer
remove unnecessary change

remove mapbox baseMap

resolve image data in BitmapLayer

enable mipmap for bitmap layer

fix typo

resolve comments

Add bbox to Tile and test
fix

@xintongxia xintongxia force-pushed the xx/tile-bitmap branch from 7663165 to 4616d21 Mar 23, 2019

@xintongxia xintongxia merged commit 185045e into master Mar 25, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@xintongxia xintongxia deleted the xx/tile-bitmap branch Mar 25, 2019

@TrantorM

This comment has been minimized.

Copy link

commented Mar 28, 2019

@xintongxia I tried to run your openstreet-map example and got an error shown in the attached image. To use the example standalone I deleted the bottom line module.exports = env... in the file webpack.config.js according the description within that file.

Bildschirmfoto 2019-03-28 um 14 59 08

Any Idea?

@ibgreen

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

@TrantorM FWIW:

If you are testing things on master, you probably want to use npm run start-local to build the example against the local source on master rather than against installed modules.

The reason is that since deck.gl v7 is still in development the published modules may not contain what you need.

@TrantorM

This comment has been minimized.

Copy link

commented Mar 29, 2019

Not able to build it on master with npm run start-local either. Can't resolve '@loaders.gl/core'.

Bildschirmfoto 2019-03-29 um 12 12 13

A git checkout tags/v7.0.0-beta.1 results in the same problem.

ajduberstein added a commit to ajduberstein/deck.gl that referenced this pull request Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.