Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add widthUnits & sizeUnits to core layers #2825

Merged
merged 3 commits into from Mar 22, 2019

Conversation

Projects
None yet
3 participants
@Pessimistress
Copy link
Contributor

Pessimistress commented Mar 21, 2019

Change List

  • Add widthUnits & sizeUnits to LineLayer, ArcLayer, PathLayer, PointCloudLayer, ScatterplotLayer, PolygonLayer and GeoJsonLayer
  • Revert recent changes made to the ContourLayer API, restore support for per-threshold stroke widths
  • Docs

@Pessimistress Pessimistress requested review from xintongxia and ibgreen Mar 21, 2019

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 21, 2019

Coverage Status

Coverage increased (+0.4%) to 59.314% when pulling c680f71 on api-updates into a219ac2 on master.


* Default: `1`

The minimum line width in pixels. This prop can be used to prevent the line from getting to thin when zoomed out.

This comment has been minimized.

Copy link
@xintongxia

xintongxia Mar 22, 2019

Contributor

to -> too?


* Default: `Number.MAX_SAFE_INTEGER`

The maximum line width in pixels. This prop can be used to prevent the line from getting to thick when zoomed in.

This comment has been minimized.

Copy link
@xintongxia

xintongxia Mar 22, 2019

Contributor

ditto

@Pessimistress Pessimistress merged commit 674dbb0 into master Mar 22, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@Pessimistress Pessimistress deleted the api-updates branch Mar 22, 2019

ajduberstein added a commit to ajduberstein/deck.gl that referenced this pull request Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.