Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable running layer-browser with local luma.gl #2855

Merged
merged 21 commits into from Mar 29, 2019

Conversation

Projects
None yet
4 participants
@ibgreen
Copy link
Contributor

commented Mar 29, 2019

For #

Background

  • Works like a charm, live edit in luma and test in layer-browser!

Change List

  • Buble can't handle ES2018, we need move JSX examples to babel (NOTE: in es6 mode we only need to transpile preset-react, Chrome can handle everything else)
  • Add new env option to link to luma.gl

ibgreen added some commits Mar 29, 2019

wip
@@ -1,3 +1,3 @@
dist/** -diff
dist-demo/** -diff
yarn.lock -diff
# yarn.lock -diff

This comment has been minimized.

Copy link
@georgios-uber

georgios-uber Mar 29, 2019

Contributor

Just delete this line. I always want to see yarn diff.

@@ -4,6 +4,7 @@
"license": "MIT",
"scripts": {
"start-local": "webpack-dev-server --env.es6 --progress --hot --open",
"start-local-luma": "webpack-dev-server --env.es6 --env.local --env.local-luma --progress --hot --open",

This comment has been minimized.

Copy link
@tsherif
@coveralls

This comment has been minimized.

Copy link

commented Mar 29, 2019

Coverage Status

Coverage decreased (-0.02%) to 60.838% when pulling daace55 on ib/beta-fixes into 0ed3cbb on master.

@ibgreen ibgreen merged commit b99cc52 into master Mar 29, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@ibgreen ibgreen deleted the ib/beta-fixes branch Mar 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.