Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples/gallery local debugging config #2932

Merged
merged 2 commits into from Apr 10, 2019
Merged

Fix examples/gallery local debugging config #2932

merged 2 commits into from Apr 10, 2019

Conversation

xintongxia
Copy link
Collaborator

Background

v7.0 audit

Change List

  • fix LOCAL_BUNDLE path
  • update readme

@coveralls
Copy link

coveralls commented Apr 10, 2019

Coverage Status

Coverage remained the same at 61.696% when pulling 3e9554e on xx/gallery into f135a65 on master.

@@ -12,7 +12,7 @@ if (!MAPBOX_TOKEN) {
}
/* eslint-enable */

const LOCAL_BUNDLE = path.resolve(__dirname, '../../../node_modules/deck.gl/dist.js');
const LOCAL_BUNDLE = path.resolve(__dirname, '../../../modules/main/dist.js');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two should be the same after running bootstrap at root.

@xintongxia xintongxia merged commit de80e6c into master Apr 10, 2019
@xintongxia xintongxia deleted the xx/gallery branch April 10, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants