Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the component-wrapping-rfc.md #3507

Merged
merged 1 commit into from Aug 29, 2019
Merged

update the component-wrapping-rfc.md #3507

merged 1 commit into from Aug 29, 2019

Conversation

@kenns29
Copy link
Contributor

kenns29 commented Aug 29, 2019

#3065 ## Background
Added something to Ib's RFC

@kenns29 kenns29 requested a review from ibgreen Aug 29, 2019
@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Aug 29, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

ibgreen left a comment

Thanks for the improvements.

I think an example illustrating the configuration object idea would be the next step.

@kenns29 kenns29 merged commit 56c4cc4 into master Aug 29, 2019
2 of 3 checks passed
2 of 3 checks passed
license/cla Contributor License Agreement is not signed yet.
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@kenns29 kenns29 deleted the hong/rfc branch Aug 29, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 29, 2019

Coverage Status

Coverage increased (+2.5%) to 83.552% when pulling a8a2ea7 on hong/rfc into 9804352 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.