Support rendering to custom framebuffer #3742
Conversation
|
Could this not be handled by the application just binding a framebuffer in the |
|
@tsherif I think any user setting will be overwritten by https://github.com/uber/deck.gl/blob/master/modules/core/src/passes/layers-pass.js#L9 |
Pessimistress
force-pushed
the
x/framebuffer
branch
from
999e169
to
4d06894
Compare
Pessimistress
force-pushed
the
x/framebuffer
branch
from
4d06894
to
37d5556
Compare
There was a problem hiding this comment.
Looks good!
I remember suggesting supporting a View.framebuffer prop in the View classes RFC allowing both screen and framebuffer rendering at the same time. I suppose that would still be possible, and would offer slightly different functionality, as this top-level framebuffer prop will cover all views.
| @@ -46,16 +47,14 @@ export default class DeckRenderer { | |||
|
|
|||
| opts.layerFilter = this.layerFilter; | |||
| opts.effects = opts.effects || []; | |||
| opts.target = opts.target || Framebuffer.getDefaultFramebuffer(this.gl); | |||
There was a problem hiding this comment.
Nit: In the spirit of consistency / typing things out and making them self-documenting, should we call this options.framebuffer or options.targetFramebuffer?
| @@ -83,11 +82,11 @@ export default class DeckRenderer { | |||
| } | |||
|
|
|||
| // Private | |||
| _preRender(effects, params) { | |||
| _preRender(effects, opts) { | |||
| @@ -57,7 +56,8 @@ export default class PickLayersPass extends LayersPass { | |||
| blend: !pickZ | |||
| }, | |||
| () => { | |||
| this.drawLayers({ | |||
| super.render({ | |||
There was a problem hiding this comment.
Nit: Any chance we can avoid introducing a call to super? What happens if we call this.render()? If we rename super.render()?
Change List
_framebufferprop toDeck