New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby bindings to community docs #160

Merged
merged 1 commit into from Dec 21, 2018

Conversation

Projects
None yet
4 participants
@seanhandley
Copy link
Contributor

seanhandley commented Dec 8, 2018

No description provided.

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Dec 8, 2018

CLA assistant check
All committers have signed the CLA.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 8, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling fd8d414 on seanhandley:patch-1 into 1fa9106 on uber:master.

@seanhandley seanhandley changed the title Add Ruby bindings Add Ruby bindings to community docs Dec 8, 2018

@nrabinowitz

This comment has been minimized.

Copy link
Contributor

nrabinowitz commented Dec 10, 2018

Thanks so much for submitting! Adding Ruby support would be great.

However, it looks like this binding isn't really implemented yet, unless I'm missing something. While it's great to let others know you're working on this, to avoid duplicate work, I'd prefer to leave this off the bindings page until it's production-ready. Thoughts?

@seanhandley

This comment has been minimized.

Copy link
Contributor

seanhandley commented Dec 10, 2018

Hi @nrabinowitz

I think that's fair.

We've wrapped around 2/3 of the API calls and expect to have the rest done soon.

I'll update this PR when we release the first tagged version.

@nrabinowitz

This comment has been minimized.

Copy link
Contributor

nrabinowitz commented Dec 10, 2018

Sounds great. Let's leave this PR open for now to signal that this work is ongoing. Thanks again for the contribution!

@seanhandley

This comment has been minimized.

Copy link
Contributor

seanhandley commented Dec 21, 2018

@nrabinowitz Ok, our first version is out https://rubygems.org/gems/h3/versions/3.2.0 !

We're matching h3 semver except for patch level, as advised by @dfellis.

Have a great Christmas! 🎄 🎅 🎁 😁

@nrabinowitz

This comment has been minimized.

Copy link
Contributor

nrabinowitz commented Dec 21, 2018

Great! Merging now, will deploy the website later today.

@nrabinowitz nrabinowitz merged commit f981948 into uber:master Dec 21, 2018

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
license/cla Contributor License Agreement is signed.
Details

@seanhandley seanhandley deleted the seanhandley:patch-1 branch Dec 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment