New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove go-build from repo #2
Conversation
# ==== MOCKS ==== | ||
|
||
mockgen = GOPATH=$(OLDGOPATH) $(GLIDE_EXEC) -g $(GLIDE) -d $(GOPATH)/bin -x github.com/golang/mock/mockgen -- mockgen | ||
mockgen = $(GLIDE_EXEC) -g $(GLIDE) -d $(GOPATH)/bin -x github.com/golang/mock/mockgen -- mockgen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$(GLIDE_EXEC)
no longer exists. You'll need to work out an alternative. Perhaps system glide will work, although I believe we ran into a lot of problems with system glide on Jenkins.
origin/origin \ | ||
proxy/proxy \ | ||
tools/bin/testfs/testfs \ | ||
tracker/tracker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we removing all system binaries?
tools/bin/reload/reload:: $(wildcard tools/bin/reload/reload/*.go) | ||
$(BUILD_LINUX) | ||
|
||
tools/bin/simulation/simulation:: $(wildcard ttools/bin/simulation/simulation/*.go) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling. s/ttools/tools
LINUX_TOOLS = \ | ||
tools/bin/reload/reload \ | ||
tools/bin/simulation/simulation \ | ||
tools/bin/trackerload/trackerload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of our tools should be restricted to linux, we should be able to run them locally. I think using the system compiler is appropriate.
|
||
.PHONY: bench | ||
bench: | ||
$(ECHO_V)cd $(FAUXROOT); $(TEST_ENV) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of these variables exist anymore.
$(ECHO_V)cd $(FAUXROOT); $(TEST_ENV) \ | ||
$(GO) test -bench=. -run=$(TEST_DIRS) | ||
|
||
update-golden: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this target. We don't have any golden files.
origin/origin | ||
proxy/proxy | ||
build-index/build-index | ||
tools/bin/testfs/testfs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is redundant. All of these binaries are declared above.
* Bump dependencies * Remove go-build
* Bump dependencies * Remove go-build
* Bump dependencies * Remove go-build
* Bump dependencies * Remove go-build
* Bump dependencies * Remove go-build
* Bump dependencies * Remove go-build
Also removed tools/benchmark.