Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove go-build from repo #2

Merged
merged 2 commits into from Dec 18, 2018
Merged

Remove go-build from repo #2

merged 2 commits into from Dec 18, 2018

Conversation

yiranwang52
Copy link
Collaborator

Also removed tools/benchmark.

@yiranwang52 yiranwang52 merged commit a4cdc62 into master Dec 18, 2018
# ==== MOCKS ====

mockgen = GOPATH=$(OLDGOPATH) $(GLIDE_EXEC) -g $(GLIDE) -d $(GOPATH)/bin -x github.com/golang/mock/mockgen -- mockgen
mockgen = $(GLIDE_EXEC) -g $(GLIDE) -d $(GOPATH)/bin -x github.com/golang/mock/mockgen -- mockgen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$(GLIDE_EXEC) no longer exists. You'll need to work out an alternative. Perhaps system glide will work, although I believe we ran into a lot of problems with system glide on Jenkins.

origin/origin \
proxy/proxy \
tools/bin/testfs/testfs \
tracker/tracker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing all system binaries?

tools/bin/reload/reload:: $(wildcard tools/bin/reload/reload/*.go)
$(BUILD_LINUX)

tools/bin/simulation/simulation:: $(wildcard ttools/bin/simulation/simulation/*.go)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling. s/ttools/tools

LINUX_TOOLS = \
tools/bin/reload/reload \
tools/bin/simulation/simulation \
tools/bin/trackerload/trackerload
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of our tools should be restricted to linux, we should be able to run them locally. I think using the system compiler is appropriate.


.PHONY: bench
bench:
$(ECHO_V)cd $(FAUXROOT); $(TEST_ENV) \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of these variables exist anymore.

$(ECHO_V)cd $(FAUXROOT); $(TEST_ENV) \
$(GO) test -bench=. -run=$(TEST_DIRS)

update-golden:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this target. We don't have any golden files.

origin/origin
proxy/proxy
build-index/build-index
tools/bin/testfs/testfs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant. All of these binaries are declared above.

@yiranwang52 yiranwang52 deleted the yiran/makefile branch December 19, 2018 03:56
yiranwang52 added a commit that referenced this pull request Dec 23, 2018
* Bump dependencies

* Remove go-build
yiranwang52 added a commit that referenced this pull request Dec 23, 2018
* Bump dependencies

* Remove go-build
yiranwang52 added a commit that referenced this pull request Dec 23, 2018
* Bump dependencies

* Remove go-build
yiranwang52 added a commit that referenced this pull request Jan 4, 2019
* Bump dependencies

* Remove go-build
yiranwang52 added a commit that referenced this pull request Jan 5, 2019
* Bump dependencies

* Remove go-build
yiranwang52 added a commit that referenced this pull request Jan 5, 2019
* Bump dependencies

* Remove go-build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants