Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ShaderCache class #110

Merged
merged 2 commits into from Nov 30, 2016
Merged

New ShaderCache class #110

merged 2 commits into from Nov 30, 2016

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Nov 29, 2016

  • new ShaderCache object. Intention: shaders that take a long time to compile should be compiled only once.
  • Program and Model constructors: Add support for supplying compiled Shader objects as vs and fs params - as an alternative to source strings - necessary to use cached shaders from ShaderCache.
  • Adds an experimental folder and a top level import, making it clear to the user that he is importing experimental code:
    import {ShaderCache} from 'luma.gl/experimental';

Intention is to allow us to iterate on APIs in the experimental folder without having to make major bumps to the luma.gl version.

@person594 - this is an example of how we can use an experimental imports file, similar to what we discussed for your deck.gl PR.

@gnavvy - As discussed yesterday - This is complementary to your Program cache in deck.gl, not a replacement.

@CLAassistant
Copy link

CLAassistant commented Nov 29, 2016

CLA assistant check
All committers have signed the CLA.

@gnavvy gnavvy merged commit 9cd206f into master Nov 30, 2016
ibgreen added a commit that referenced this pull request May 1, 2017
* New ShaderCache class

* Remove glslify. Per submodule .babelrc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants