Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShaderCache
object. Intention: shaders that take a long time to compile should be compiled only once.Program
andModel
constructors: Add support for supplying compiledShader
objects asvs
andfs
params - as an alternative to source strings - necessary to use cached shaders fromShaderCache
.experimental
folder and a top level import, making it clear to the user that he is importing experimental code:Intention is to allow us to iterate on APIs in the experimental folder without having to make major bumps to the luma.gl version.
@person594 - this is an example of how we can use an experimental imports file, similar to what we discussed for your deck.gl PR.
@gnavvy - As discussed yesterday - This is complementary to your
Program
cache in deck.gl, not a replacement.