Add test case and fix for glGetDebugInfo regression under Node. #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnavvy
reviewed
Nov 30, 2016
| @@ -1,24 +1,27 @@ | |||
| // No headless | |||
| // import './context-no-headless.spec'; | |||
There was a problem hiding this comment.
do we need this line to include the new test?
There was a problem hiding this comment.
Good question
No that file is imported from a different test run (without headless-gl imported).
We run with and without headless gl. I have pushed a commit that removes the commented line in this index.js file.
ibgreen
added a commit
that referenced
this pull request
May 1, 2017
* Add test case and fix for glGetDebugInfo regression under Node. * Add "experimental.js" to exported "files" in package.json. * Add comments to some top-level test index.js files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shaojingli @gnavvy - quick regression fix.