Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose glTF API as function call #951

Merged
merged 2 commits into from Mar 6, 2019

Conversation

Projects
None yet
2 participants
@ibgreen
Copy link
Contributor

ibgreen commented Mar 5, 2019

For #702

Background

  • Just expose a function to instantiate glTF, not a class

Change List

  • Reorganize code a little

@ibgreen ibgreen requested a review from georgios-uber Mar 5, 2019

const scenes = instantiator.instantiate(gltf);
const animator = instantiator.createAnimator();

const {scenes, animator} = createGLTFObjects(gl, gltf)

This comment has been minimized.

Copy link
@georgios-uber

georgios-uber Mar 5, 2019

Contributor

What happened to options??

This comment has been minimized.

Copy link
@ibgreen

ibgreen Mar 6, 2019

Author Contributor

What happened to options??

Thanks, that was it! That fixed the iffy rendering in the example!

@ibgreen ibgreen force-pushed the ib/gltf-function branch from 1fcfef0 to e6d6eb8 Mar 6, 2019

@ibgreen ibgreen merged commit ab8a30f into master Mar 6, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@ibgreen ibgreen deleted the ib/gltf-function branch Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.