Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for mat attribute types #959

Merged
merged 1 commit into from Mar 9, 2019

Conversation

Projects
None yet
3 participants
@georgios-uber
Copy link
Contributor

commented Mar 8, 2019

add support for mat attribute types

@georgios-uber georgios-uber self-assigned this Mar 8, 2019

@georgios-uber georgios-uber requested a review from ibgreen Mar 8, 2019

@Pessimistress Pessimistress requested a review from tsherif Mar 8, 2019

@ibgreen

ibgreen approved these changes Mar 8, 2019

Copy link
Contributor

left a comment

Great PoC, there is a good idea here!

Very open to supporting e.g. a naming convention to handle this case, but to ensure that the feature actually becomes useful (e.g. users can discover and understand it), and that it doesn't break in the next refactor it needs to be:

  • documented
  • have test cases.
  • Use well commented code.
  • use helpful variable names, e.g:
    • don't use neutral names like x, when a self-documenting name could have helped the reader.
    • Assign the regexp to a well named constant etc const COMPOSITE_ATTRIBUTE_REGEXP = ''; (I am sure better name is possible, but you get the idea).

@georgios-uber georgios-uber force-pushed the mat-attrib branch from a5766d4 to d3cbc34 Mar 9, 2019

@georgios-uber georgios-uber marked this pull request as ready for review Mar 9, 2019

@georgios-uber georgios-uber requested review from Pessimistress and ibgreen Mar 9, 2019

@tsherif

This comment has been minimized.

Copy link
Member

commented Mar 9, 2019

This is great! I think the last step would be to automate the setting up the attribute pointers, instead of having to to explicitly create ..._LOCATION_1, etc. Those names could be used internally, but the user could just declare a mat2, mat3 or mat4 attributes, and Luma would set up the 2, 3, or 4 attributes automatically. Would keep the user from having to do this kind of this, which is the more painful part of dealing with matrix attributes: https://github.com/uber/luma.gl/blob/master/examples/core/dof/app.js#L111-L144

@tsherif

tsherif approved these changes Mar 9, 2019

@georgios-uber georgios-uber merged commit c236705 into master Mar 9, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@georgios-uber georgios-uber deleted the mat-attrib branch Mar 9, 2019

@tsherif tsherif referenced this pull request Apr 11, 2019

Closed

Add ability to support a matrix as instance attribute #783

0 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.